IS-2621: Add stansdato datepicker #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetlesolgaard
force-pushed
the
IS-2621-Add-possibility-to-add-stansdato-in-instilling-to-NAY
branch
5 times, most recently
from
c12b448
to
078e266
Compare
vetlesolgaard
changed the title
vetlesolgaard
force-pushed
the
IS-2621-Add-possibility-to-add-stansdato-in-instilling-to-NAY
branch
4 times, most recently
from
ae1d194
to
6038a16
Compare
| const { datepickerProps, inputProps } = useDatepicker({ | ||
| fromDate: varselSvarfrist, | ||
| onDateChange: (date: Date | undefined) => { | ||
| if (!!date) { |
There was a problem hiding this comment.
Trenger man håndtere setting og clearing av errors her?
Ser ikke ut som vi gjør det i AvslagDatePicker og VedtakFraDato hvor vi også har en påkrevd dato. Hadde vært nice å slippe kode for det her også, kanskje det er lettere om man skiller det ut som egen komponent? :)
There was a problem hiding this comment.
Er litt redd for controlled components ettersom jeg ikke helt forstår hvordan det fungerer, men var ikke så mye greier så måtte til ser jeg. Endrer 🚀
There was a problem hiding this comment.
Synes det blir litt vel magisk med FormProvider, men fant ikke en alternativ måte, så da blir det det 🥲
andersrognstad
approved these changes
Oct 4, 2024
vetlesolgaard
force-pushed
the
IS-2621-Add-possibility-to-add-stansdato-in-instilling-to-NAY
branch
from
6038a16
to
29ae1df
Compare
vetlesolgaard
deleted the
IS-2621-Add-possibility-to-add-stansdato-in-instilling-to-NAY
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈
Legger til felt for stansdato på innstillingen om stans som går til NAY.
Se tilhørende PR i ismanglendemedvirkning
Screenshots 📸✨
Screen.Recording.2024-10-03.at.13.24.15.mov